[PATCH] D79248: [lld][WebAssembly] Implement --unresolved-symbols

Tue Nov 17 12:47:25 PST 2020

MaskRay added a comment.

In D79248#2400523 <https://reviews.llvm.org/D79248#2400523>, @sbc100 wrote:

> @MaskRay any objections to landing this?
>
> BTW, how to you feel about being a reviewer on wasm-ld change in general.. if you are OK with it I could use a reviewer for my work here now that @Rui is less active.

I don't mind but you'll throw out some learning resources on me.. (Persoanlly I do want to study more binary formats) For now I guess the best I can provide is how some options are used in ELF..

I just committed D91510 <https://reviews.llvm.org/D91510> for ELF - personally I think the option is a bit awkward to use as it changes two bits simultaneously. There are more values in the wasm-lld version: do you think these values should all be mutually exclusive. If yes, this looks fine to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79248/new/

https://reviews.llvm.org/D79248