[PATCH] D91632: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to emit

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 09:18:22 PST 2020


foad added inline comments.


================
Comment at: llvm/utils/TableGen/DAGISelMatcherEmitter.cpp:51
 
+  SmallVector<unsigned, Matcher::HighestKind+1> OpcodeCounts;
+
----------------
Paul-C-Anagnostopoulos wrote:
> foad wrote:
> > Did you mean to include this in this patch? It seems unrelated.
> This part of the update eliminates the extra pass over the matcher tree just to count the matcher kinds for the histogram. The counting was merged into the new first pass for sizing.
Fair enough, sounds good!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91632/new/

https://reviews.llvm.org/D91632



More information about the llvm-commits mailing list