[PATCH] D91637: [WebAssembly] Only emit indirect function table import if needed

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 08:59:35 PST 2020


sbc100 added a comment.

This looks pretty much like I was suggesting, although I was hoping we could make it more isolated by just making the creation of the existing table import conditional rather than creating a new MC symbol.



================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:506
+    BaseSym->setUsedInReloc();
+    Asm.registerSymbol(*BaseSym);
+  }
----------------
Can we just move the code below, or make it conditional to avoid the MCConteext changes?

 (i.e. can we make this change local to this file?)




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91637/new/

https://reviews.llvm.org/D91637



More information about the llvm-commits mailing list