[PATCH] D90935: [ARM][LowOverheadLoops] Merge VCMP and VPST across VPT blocks

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1524
         //   the divergent vpr def.
         // TODO: We could be producing more VPT blocks than necessary and could
         // fold the newly created one into a proceeding one.
----------------
Can this TODO be removed now?


================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1566
       LoLoop.BlockMasksToRecompute.insert(Insts.front());
+    } else if (Insts.front()->getOpcode() == ARM::MVE_VPST) {
+      MachineInstr *VPST = Insts.front();
----------------
Don't worry about putting it up for review, but before committing would you mind adding a comment about what condition(s) this logic is handling, like there is for the other conditional blocks?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90935/new/

https://reviews.llvm.org/D90935