[PATCH] D91632: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to emit

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Looks good to me. I'm looking forward to the improved build times.



================
Comment at: llvm/utils/TableGen/DAGISelMatcherEmitter.cpp:51
 
+  SmallVector<unsigned, Matcher::HighestKind+1> OpcodeCounts;
+
----------------
Did you mean to include this in this patch? It seems unrelated.


================
Comment at: llvm/utils/TableGen/DAGISelMatcherEmitter.cpp:978
 
-static void BuildHistogram(const Matcher *M, std::vector<unsigned> &OpcodeFreq){
-  for (; M != nullptr; M = M->getNext()) {
----------------
Seems unrelated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91632/new/

https://reviews.llvm.org/D91632