[PATCH] D91635: [WebAssembly] Fix parsing of linking section for named global imports

Andy Wingo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 07:59:06 PST 2020


wingo created this revision.
Herald added subscribers: llvm-commits, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff.
Herald added a project: LLVM.
wingo requested review of this revision.
Herald added a subscriber: aheejin.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91635

Files:
  llvm/lib/Object/WasmObjectFile.cpp
  llvm/test/MC/WebAssembly/debug-info.ll
  llvm/test/MC/WebAssembly/debug-info64.ll


Index: llvm/test/MC/WebAssembly/debug-info64.ll
===================================================================
--- llvm/test/MC/WebAssembly/debug-info64.ll
+++ llvm/test/MC/WebAssembly/debug-info64.ll
@@ -219,7 +219,6 @@
 ; CHECK-NEXT:     Flags [ (0x10)
 ; CHECK-NEXT:       UNDEFINED (0x10)
 ; CHECK-NEXT:     ]
-; CHECK-NEXT:     ImportName: __stack_pointer
 ; CHECK-NEXT:     ImportModule: env
 ; CHECK-NEXT:     ElementIndex: 0x0
 ; CHECK-NEXT:   }
Index: llvm/test/MC/WebAssembly/debug-info.ll
===================================================================
--- llvm/test/MC/WebAssembly/debug-info.ll
+++ llvm/test/MC/WebAssembly/debug-info.ll
@@ -219,7 +219,6 @@
 ; CHECK-NEXT:    Flags [ (0x10)
 ; CHECK-NEXT:      UNDEFINED (0x10)
 ; CHECK-NEXT:    ]
-; CHECK-NEXT:    ImportName: __stack_pointer
 ; CHECK-NEXT:    ImportModule: env
 ; CHECK-NEXT:    ElementIndex: 0x0
 ; CHECK-NEXT:  }
Index: llvm/lib/Object/WasmObjectFile.cpp
===================================================================
--- llvm/lib/Object/WasmObjectFile.cpp
+++ llvm/lib/Object/WasmObjectFile.cpp
@@ -562,7 +562,6 @@
           Info.Name = Import.Field;
         }
         GlobalType = &Import.Global;
-        Info.ImportName = Import.Field;
         if (!Import.Module.empty()) {
           Info.ImportModule = Import.Module;
         }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91635.305798.patch
Type: text/x-patch
Size: 1336 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201117/82256d37/attachment.bin>


More information about the llvm-commits mailing list