[PATCH] D89418: [lld-macho] Implement LC_UUID

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 06:27:22 PST 2020


int3 added a comment.

I used MD5 since that's what ld64 does. I hadn't looked at what lld-ELF/COFF were doing for this though, so thanks for the pointer! The only possible concern I can think of is the fact that the UUID version tags as specified in its RFC only provide for MD5 or SHA1 hashing, and ld64 seemed to think it important that we conform to this RFC. But I'm hard pressed to see how it would be an issue if we used a different hashing algorithm but tagged it as MD5. I'm inclined to just leave a TODO for now and come back later when we are tuning for performance


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89418/new/

https://reviews.llvm.org/D89418



More information about the llvm-commits mailing list