[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/lib/AST/Stmt.cpp:795
+  SmallVector<StringRef, 8> Pieces;
+  AsmStr.split(Pieces, "\n\t");
+  std::string MSAsmString;
----------------
Can we always assume the separator is `\n\t`?


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3083
+      }
+      if (IsPrefix) {
+        NameLoc = Parser.getTok().getLoc();
----------------
You just need to check `ForcedVEXEncoding != VEXEncoding_Default`.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3084
+      if (IsPrefix) {
+        NameLoc = Parser.getTok().getLoc();
+        if (getLexer().isNot(AsmToken::Identifier))
----------------
Unused assignment. It may suppose to be used on line 3086.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90441/new/

https://reviews.llvm.org/D90441