[PATCH] D91510: [ELF] Fix interaction between --unresolved-symbols= and --[no-]allow-shlib-undefined

[Peter Smith via Phabricator via llvm-commits]

psmith accepted this revision.
psmith added a comment.
This revision is now accepted and ready to land.

LGTM, with one suggestion of a name change. I've checked the GNU ld behaviour against the green test changes and LLD matches.



================
Comment at: lld/ELF/Driver.cpp:587
 // symbols after the name resolution.
-static UnresolvedPolicy getUnresolvedSymbolPolicy(opt::InputArgList &args) {
+static void getUnresolvedSymbolPolicy(opt::InputArgList &args) {
   UnresolvedPolicy errorOrWarn = args.hasFlag(OPT_error_unresolved_symbols,
----------------
Perhaps call this setUnresolvedSymbolPolicy as it isn't returning anything and is modifying config as a side effect.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91510/new/

https://reviews.llvm.org/D91510