[PATCH] D91604: [WebAssembly] Remove useless overrides in MCWasmStreamer
Andy Wingo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 17 02:08:09 PST 2020
wingo created this revision.
Herald added subscribers: llvm-commits, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff.
Herald added a project: LLVM.
wingo requested review of this revision.
Herald added a subscriber: aheejin.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D91604
Files:
llvm/include/llvm/MC/MCWasmStreamer.h
llvm/lib/MC/MCWasmStreamer.cpp
Index: llvm/lib/MC/MCWasmStreamer.cpp
===================================================================
--- llvm/lib/MC/MCWasmStreamer.cpp
+++ llvm/lib/MC/MCWasmStreamer.cpp
@@ -148,18 +148,6 @@
llvm_unreachable("Local common symbols are not yet implemented for Wasm");
}
-void MCWasmStreamer::emitValueImpl(const MCExpr *Value, unsigned Size,
- SMLoc Loc) {
- MCObjectStreamer::emitValueImpl(Value, Size, Loc);
-}
-
-void MCWasmStreamer::emitValueToAlignment(unsigned ByteAlignment, int64_t Value,
- unsigned ValueSize,
- unsigned MaxBytesToEmit) {
- MCObjectStreamer::emitValueToAlignment(ByteAlignment, Value, ValueSize,
- MaxBytesToEmit);
-}
-
void MCWasmStreamer::emitIdent(StringRef IdentString) {
// TODO(sbc): Add the ident section once we support mergable strings
// sections in the object format
Index: llvm/include/llvm/MC/MCWasmStreamer.h
===================================================================
--- llvm/include/llvm/MC/MCWasmStreamer.h
+++ llvm/include/llvm/MC/MCWasmStreamer.h
@@ -59,13 +59,9 @@
SMLoc Loc = SMLoc()) override;
void emitTBSSSymbol(MCSection *Section, MCSymbol *Symbol, uint64_t Size,
unsigned ByteAlignment = 0) override;
- void emitValueImpl(const MCExpr *Value, unsigned Size,
- SMLoc Loc = SMLoc()) override;
void emitIdent(StringRef IdentString) override;
- void emitValueToAlignment(unsigned, int64_t, unsigned, unsigned) override;
-
void finishImpl() override;
private:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91604.305705.patch
Type: text/x-patch
Size: 1673 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201117/f8640a4b/attachment.bin>
More information about the llvm-commits
mailing list