[PATCH] D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA.

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

I saw some testcases are removed compared with your committed version. Is there any reason?



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:3257
+      SrcMI->definesRegister(SrcMI->getOperand(1).getReg()))
+    return false;
   // If MBMI is bigger than MEMI, we always can not get run of ones.
----------------
Can these lines be moved after line 3221? So we will bail out early.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:3360
+    if (MRI->isSSA())
+      CanErase = !SrcMI->hasImplicitDef() && MRI->use_nodbg_empty(FoldingReg);
+    if (CanErase) {
----------------
Can we move `CanErase` assignment for SSA to the place where we assign it for post SSA?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89855/new/

https://reviews.llvm.org/D89855