[PATCH] D91343: [InstCombine] Optimize away the unnecessary multi-use sign-extend

[Bhramar Vatsa via Phabricator via llvm-commits]

Bhramar.vatsa added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:922
     // Compute the Known bits to simplify things downstream.
     computeKnownBits(I, Known, Depth, CxtI);
 
----------------
For this patch, this call will no more happen, even when the 'case AShr' doesn't match completely. So, should a call to computeKnownBits(), be added in that case?
The call isn't there for other cases, but there, perhaps it isn't needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91343/new/

https://reviews.llvm.org/D91343