[PATCH] D61767: [llvm-elfabi] Emit ELF header and string table section

[Haowei Wu via Phabricator via llvm-commits]

haowei marked 3 inline comments as done.
haowei added inline comments.


================
Comment at: llvm/test/tools/llvm-elfabi/write-elf32le-stub.test:1
+# Test writing 32bit little endinan stub elf with minimal sections.
+
----------------
jhenderson wrote:
> It might make more sense to merge the ELF32/ELF64 and LE/BE tests all into a single test. Your test would look something like:
> 
> ```
> # RUN: llvm-elfabi %s --output-target=elf32-little %t32-little
> # RUN: llvm-readobj -h -S --string-dump .shstrtab --string-dump .dynstr %t32-little | FileCheck %s -DCLASS="32-bit (0x1)" <other defines here for the other bits that are slightly different>
> # RUN: llvm-elfabi %s --output-target=elf32-big %t32-b ig
> # RUN: llvm-readobj -h -S --string-dump .shstrtab --string-dump .dynstr %t32-big | FileCheck %s -DCLASS="32-bit (0x1)" <other defines here for the other bits that are slightly different>
> <same for 64-bit variants>
> ```
I combined 4 test files into 1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61767/new/

https://reviews.llvm.org/D61767