[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

Tue Nov 17 00:20:31 PST 2020

jhenderson added a comment.

In D85474#2398858 <https://reviews.llvm.org/D85474#2398858>, @MaskRay wrote:

> Sent https://lists.llvm.org/pipermail/llvm-dev/2020-November/146676.html "Add -fbinutils-version=" (cross posted to cfe-dev) so that more folks can notice it.
>
> About "generate code that doesn't care about GNU as/ld compatibility/limitation", I am open for suggestions. Currently I like `-fbinutils-version=none` the most (after considering `future` and `latest` and `99` (assuming GNU binutils 99 implements everything we need...))

I like `none`. `latest` has some connotations that we attempt compatibility with some specific bleeding edge set of tools, which might not be true, especially if they've released at a different time point to us. `none` implies there is no specific guarantee for compatibility to me. `99` (or other number) seems risky/short-sighted given the way versioning sometimes shoots up versus the longetivity of some of these code bases.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85474/new/

https://reviews.llvm.org/D85474