[PATCH] D91533: [lib/Object] - Generalize the RelocationResolver API.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Seems reasonable. RelocationRef may be awkward to use just because it needs an `OwningObject`.



================
Comment at: llvm/lib/Object/RelocationResolver.cpp:42
 
-static uint64_t resolveX86_64(RelocationRef R, uint64_t S, uint64_t A) {
-  switch (R.getType()) {
+static uint64_t resolveX86_64(uint64_t Type, uint64_t Offset, uint64_t S,
+                              uint64_t LocData, int64_t Addend) {
----------------
You have changed the addend parameter from uint64_t to int64_t. What's the motivation?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91533/new/

https://reviews.llvm.org/D91533