[PATCH] D91583: [lld] Allow --export-dynamic to override --lto-whole-program-visibility

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

I'll need to study what whole program visibility does (e.g. I need to read http://lists.llvm.org/pipermail/llvm-dev/2019-December/137543.html "RFC: Safe Whole Program Devirtualization Enablement").
My gut feeling is that: `--export-dynamic` is not sufficient to capture whether symbols are exported.
When linking an executable,

- Symbols matched by a `--dynamic-list` pattern are exported to the dynamic symbol table
- Symbols matched by a `--export-dynamic-symbol` pattern exported to the dynamic symbol table

If the usage of `--export-dynamic` means whether the mode should apply to synthesized new symbols, I think having a mode referring to `--export-dynamic` makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91583/new/

https://reviews.llvm.org/D91583