[PATCH] D91151: [VE][NFC] Change cast to dyn_cast

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 19:26:26 PST 2020


dblaikie added a comment.

Can you add a test case for this change?

If this change is not testable (eg: if all "Addr" that can reach this code are ConstantSDNodes) then it may be more suitable to remove the conditional and leave the cast in until code is committed that makes this live - that way we can be sure test coverage is added when the code is added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91151/new/

https://reviews.llvm.org/D91151



More information about the llvm-commits mailing list