[PATCH] D91323: [PowerPC] Add support for intrinsics dcbfps and dcbstps in P10.

[EsmeYi via Phabricator via llvm-commits]

Esme added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:38
+  def int_ppc_dcbfps : Intrinsic<[], [llvm_ptr_ty], []>;
+  def int_ppc_dcbstps: Intrinsic<[], [llvm_ptr_ty], []>;
 
----------------
steven.zhang wrote:
> I didn't go into the detail of the definition of the intrinsic. But could you please double confirm if we need to set `IntrWriteMem, IntrArgMemOnly` as it seems that dbcf stuff is trying to write memory.
Thanks for your comment. The dcbf_ instructions perform the writes to main storage instead of memory. So there is no need to set `IntrWriteMem, IntrArgMemOnly`. Please correct me if I am wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91323/new/

https://reviews.llvm.org/D91323