[PATCH] D88988: [llvm-symbolizer] Add inline stack traces for Windows.

[Amy Huang via Phabricator via llvm-commits]

akhuang added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/PDB/Native/NativeSession.h:133
+  IMap::Allocator IMapAllocator;
+  IMap AddrToModuleIndex;
 };
----------------
rnk wrote:
> You know, we shouldn't actually need to create this intermediate data structure. The section contributions in the PDB are sorted by ascending RVA. It should be possible to binary search them directly with `std::lower_bound` without building a new interval map data structure.
> 
> But, I see you are just moving this code around, so this can be a follow-up optimization.
Hm, yeah, I'll look at it later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88988/new/

https://reviews.llvm.org/D88988