[PATCH] D91579: [ELF] --gc-sections: collect unused .gcc_except_table in section groups and associated text sections

[Eric Christopher via Phabricator via llvm-commits]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

I think this is reasonable, if neither George or Peter say anything I think this looks ok to me.



================
Comment at: lld/ELF/MarkLive.cpp:115-116
+    // section.
+    if (!isLSDA ||
+        (!(relSec->flags & SHF_EXECINSTR) && !relSec->nextInSectionGroup))
       enqueue(relSec, offset);
----------------
That's an awful lot of ! in that if condition - perhaps that could be rewritten?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91579/new/

https://reviews.llvm.org/D91579