[PATCH] D91505: ELFAsmParser: Remove non-executable sections' line info/address ranges contribution for -g

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

> The new behavior seems reasonable and matches GNU as 2.36 https://sourceware.org/bugzilla/show_bug.cgi?id=26850

Probably worth including a bit more detail from that bug (it's useful to know that you filed/fixed that bug - not that that discredits the work, but clarifies that the sentiment (while endorsed by the bug/patches being approved by other members of the compiler community) was initially expressed/motivated/brought up by you there as well). Maybe something like "My patch to implement similar functionality in GNU binutils was accepted and released in GNU binutils 2.36" or the like might be suitable.

Does this LLVM patch include the same generalization discussed in the GNU Binutils bug ( https://sourceware.org/bugzilla/show_bug.cgi?id=26850#c2 ) regarding non-loaded sections?



================
Comment at: llvm/test/MC/ARM/dwarf-asm-multiple-sections.s:74-79
 // DWARF-DL-5-NEXT: 0x0000000000000004     21      0      0   0   0  is_stmt end_sequence
-// DWARF-DL-4:      0x0000000000000000     17      0      1   0   0  is_stmt
-// DWARF-DL-4-NEXT: 0x0000000000000004     17      0      1   0   0  is_stmt end_sequence
-// DWARF-DL-4-NEXT: 0x0000000000000000     21      0      1   0   0  is_stmt
-// DWARF-DL-4-NEXT: 0x0000000000000004     21      0      1   0   0  is_stmt end_sequence
+// DWARF-DL-3:      0x0000000000000000     17      0      1   0   0  is_stmt
+// DWARF-DL-3-NEXT: 0x0000000000000004     17      0      1   0   0  is_stmt end_sequence
+// DWARF-DL-3-NEXT: 0x0000000000000000     21      0      1   0   0  is_stmt
+// DWARF-DL-3-NEXT: 0x0000000000000004     21      0      1   0   0  is_stmt end_sequence
+// DWARF-DL-EMPTY:
----------------
Why the change to DWARFv3 here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91505/new/

https://reviews.llvm.org/D91505