[PATCH] D91470: Switch libLLVMFrontendOpenACC to be a regular CMake library and not a "component"

Mon Nov 16 14:54:17 PST 2020

Meinersbur added a comment.

In D91470#2395495 <https://reviews.llvm.org/D91470#2395495>, @mehdi_amini wrote:

>> In D91470#2395433 <https://reviews.llvm.org/D91470#2395433>, @mehdi_amini wrote:
>>
>>> We should dig in the OpenMP side as well.
>>
>> What do you mean by that?
>
> I mean that commenting out `OMP.cpp` here: https://github.com/llvm/llvm-project/blob/master/llvm/lib/Frontend/OpenMP/CMakeLists.txt#L6 and running `ninja check-llvm` just works.

I see. We should add some unittests for the functions in that file.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91470/new/

https://reviews.llvm.org/D91470