[PATCH] D69814: [Scheduling] Enable AA in PostRA Machine scheduler

Mon Nov 16 12:36:31 PST 2020

jroelofs added a comment.

In D69814#2397954 <https://reviews.llvm.org/D69814#2397954>, @jroelofs wrote:

> Since this adds a dependency on the AAResultsWrapperPass, shouldn't we be informing the pass manager about it?
>
>   diff --git a/llvm/lib/CodeGen/MachineScheduler.cpp b/llvm/lib/CodeGen/MachineScheduler.cpp
>   index 256628a179ae..950c87ea26f9 100644
>   --- a/llvm/lib/CodeGen/MachineScheduler.cpp
>   +++ b/llvm/lib/CodeGen/MachineScheduler.cpp
>   @@ -240,8 +240,11 @@ char PostMachineScheduler::ID = 0;
>    
>    char &llvm::PostMachineSchedulerID = PostMachineScheduler::ID;
>    
>   -INITIALIZE_PASS(PostMachineScheduler, "postmisched",
>   -                "PostRA Machine Instruction Scheduler", false, false)
>   +INITIALIZE_PASS_BEGIN(PostMachineScheduler, "postmisched",
>   +                      "PostRA Machine Instruction Scheduler", false, false)
>   +INITIALIZE_PASS_DEPENDENCY(AAResultsWrapperPass)
>   +INITIALIZE_PASS_END(PostMachineScheduler, "postmisched",
>   +                    "PostRA Machine Instruction Scheduler", false, false)
>    
>    PostMachineScheduler::PostMachineScheduler() : MachineSchedulerBase(ID) {
>      initializePostMachineSchedulerPass(*PassRegistry::getPassRegistry());

https://reviews.llvm.org/D91561

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69814/new/

https://reviews.llvm.org/D69814