[PATCH] D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68k.td:38
+  : SubtargetFeature<"x40", "SubtargetKind", "M40", "Is M68040 ISA supported",
+    [ FeatureISAx30 ]>;
+
----------------
68060 support?


================
Comment at: llvm/lib/Target/M68k/M68kCallingConv.td:12
+/// conventions assume Int to be 4 bytes and 4 byte aligned. Short variant is
+/// not supported yet.
+///
----------------
/// TODO Short variant is not supported yet.


================
Comment at: llvm/lib/Target/M68k/M68kInstrFormats.td:44
+///
+/// Operand can be quilified with size where appropriate to force a particular
+/// instruction encoding, e.g.:
----------------
qualified


================
Comment at: llvm/lib/Target/M68k/M68kInstrFormats.td:53
+///
+/// Some forms alreay imply a particular size of their operands, e.g.:
+///    (i,An)                   p       1 extension word and i is 16bit
----------------
already


================
Comment at: llvm/lib/Target/M68k/M68kInstrFormats.td:85
+
+/// Add plain bit to the instruciton
+class MxBead1Bit  <bits<1> b> : MxBead<0x1, b>;
----------------
instruction


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88389/new/

https://reviews.llvm.org/D88389