[PATCH] D89562: [flang]Add Parser Support for OpenMP Allocate Directive

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan requested changes to this revision.
kiranchandramohan added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/lib/Parser/openmp-parsers.cpp:478
 
+// 2.11.3 Executable Allocate directive
+TYPE_PARSER(sourced(construct<OpenMPExecutableAllocate>(
----------------
The standard supports a list of openmp allocates associated with a single fortran allocate. Can you extend this to include the list?

!$omp allocate[(list)] clause
[!$omp allocate[(list)] clause
[...]]


================
Comment at: flang/test/Parser/omp-allocate-unparse.f90:26
+
+!CHECK: !$OMP ALLOCATE
----------------
This check is probably not sufficient. Can you check for all the openmp allocates and the fortran allocate statements?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89562/new/

https://reviews.llvm.org/D89562