[PATCH] D91450: [BPI] Look through bitcasts in calcZeroHeuristic

[Wei Wang via Phabricator via llvm-commits]

weiwang updated this revision to Diff 305555.
weiwang added a comment.

add test case


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91450/new/

https://reviews.llvm.org/D91450

Files:
  llvm/lib/Analysis/BranchProbabilityInfo.cpp
  llvm/test/Analysis/BranchProbabilityInfo/hoist.ll


Index: llvm/test/Analysis/BranchProbabilityInfo/hoist.ll
===================================================================
--- /dev/null
+++ llvm/test/Analysis/BranchProbabilityInfo/hoist.ll
@@ -0,0 +1,63 @@
+; RUN: opt < %s -analyze -branch-prob -enable-new-pm=0 | FileCheck %s
+; RUN: opt < %s -passes='print<branch-prob>' -disable-output 2>&1 | FileCheck %s
+
+; CHECK-LABEL: no_hoist
+; CHECK: edge entry -> if.end probability is 0x40000000 / 0x80000000 = 50.00%
+; CHECK: edge entry -> if.then probability is 0x40000000 / 0x80000000 = 50.00%
+; CHECK: edge if.end -> if.end4 probability is 0x40000000 / 0x80000000 = 50.00%
+; CHECK: edge if.end -> if.then3 probability is 0x40000000 / 0x80000000 = 50.00%
+define dso_local void @no_hoist(i64 %arg1, i64 %arg2) local_unnamed_addr #0 {
+entry:
+  %and = and i64 %arg1, 1152921504606846976
+  %tobool.not = icmp eq i64 %and, 0
+  br i1 %tobool.not, label %if.end, label %if.then
+
+if.then:                                          ; preds = %entry
+  tail call void @bar()
+  br label %if.end
+
+if.end:                                           ; preds = %if.then, %entry
+  %and1 = and i64 %arg2, 1152921504606846976
+  %tobool2.not = icmp eq i64 %and1, 0
+  br i1 %tobool2.not, label %if.end4, label %if.then3
+
+if.then3:                                         ; preds = %if.end
+  tail call void @baz()
+  br label %if.end4
+
+if.end4:                                          ; preds = %if.then3, %if.end
+  ret void
+}
+
+; CHECK-LABEL: hoist
+; CHECK: edge entry -> if.end probability is 0x40000000 / 0x80000000 = 50.00%
+; CHECK: edge entry -> if.then probability is 0x40000000 / 0x80000000 = 50.00%
+; CHECK: edge if.end -> if.end4 probability is 0x40000000 / 0x80000000 = 50.00%
+; CHECK: edge if.end -> if.then3 probability is 0x40000000 / 0x80000000 = 50.00%
+define dso_local void @hoist(i64 %arg1, i64 %arg2) local_unnamed_addr #0 {
+entry:
+  %const = bitcast i64 1152921504606846976 to i64
+  %and = and i64 %arg1, %const
+  %tobool.not = icmp eq i64 %and, 0
+  br i1 %tobool.not, label %if.end, label %if.then
+
+if.then:                                          ; preds = %entry
+  tail call void @bar()
+  br label %if.end
+
+if.end:                                           ; preds = %if.then, %entry
+  %and1 = and i64 %arg2, %const
+  %tobool2.not = icmp eq i64 %and1, 0
+  br i1 %tobool2.not, label %if.end4, label %if.then3
+
+if.then3:                                         ; preds = %if.end
+  tail call void @baz()
+  br label %if.end4
+
+if.end4:                                          ; preds = %if.then3, %if.end
+  ret void
+}
+
+declare dso_local void @bar() local_unnamed_addr #1
+
+declare dso_local void @baz() local_unnamed_addr #1
Index: llvm/lib/Analysis/BranchProbabilityInfo.cpp
===================================================================
--- llvm/lib/Analysis/BranchProbabilityInfo.cpp
+++ llvm/lib/Analysis/BranchProbabilityInfo.cpp
@@ -882,7 +882,7 @@
   // we don't have information about probabilities.
   if (Instruction *LHS = dyn_cast<Instruction>(CI->getOperand(0)))
     if (LHS->getOpcode() == Instruction::And)
-      if (ConstantInt *AndRHS = dyn_cast<ConstantInt>(LHS->getOperand(1)))
+      if (ConstantInt *AndRHS = GetConstantInt(LHS->getOperand(1)))
         if (AndRHS->getValue().isPowerOf2())
           return false;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91450.305555.patch
Type: text/x-patch
Size: 3351 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201116/18a08405/attachment.bin>