[PATCH] D87798: [NewPM][CGSCC] Handle newly added functions in updateCGAndAnalysisManagerForPass

Mon Nov 16 09:02:35 PST 2020

lxfind added a comment.

In D87798#2395800 <https://reviews.llvm.org/D87798#2395800>, @aeubanks wrote:

> Yes I'm aware of the issue and https://reviews.llvm.org/D88714 is an attempt to fix that. I was going to ask exactly what sorts of transformations coroutines does. I'll make a post in llvm-dev.

I just double checked, D88714 <https://reviews.llvm.org/D88714> is going to fix https://bugs.llvm.org/show_bug.cgi?id=48176  but not the issue I mentioned above.
In the case of recursion, it will form cycles in the newly added functions, which the current SCC update cannot handle. The assertion will fail here:
https://github.com/llvm/llvm-project/blob/master/llvm/lib/Analysis/CGSCCPassManager.cpp#L409

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87798/new/

https://reviews.llvm.org/D87798