[PATCH] D91437: [AMDGPU][GlobalISel] Fix lowerShlSat

Mirko Brkusanin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 16 08:29:58 PST 2020


mbrkusanin added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-sshlsat.mir:221
+    ; GFX8: [[C:%[0-9]+]]:_(s32) = G_CONSTANT i32 8
+    ; GFX8: [[LSHR:%[0-9]+]]:_(s32) = G_LSHR [[COPY]], [[C]](s32)
+    ; GFX8: [[C1:%[0-9]+]]:_(s32) = G_CONSTANT i32 16
----------------
arsenm wrote:
> I'm surprised there are this many changes
Previous MIR still had G_SSHLSAT. And most these new shifts end up dead immediately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91437/new/

https://reviews.llvm.org/D91437



More information about the llvm-commits mailing list