[PATCH] D91028: [llvm-objcopy][NFC] replace class Buffer/MemBuffer/FileBuffer with streams.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 16 04:14:33 PST 2020
grimar added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:100
+
+ for (const auto &Phdr : *PhdrsOrErr) {
+ if (Phdr.p_type != ELF::PT_NOTE)
----------------
avl wrote:
> grimar wrote:
> > I'd not use `auto` here. You can use an actual type instead.
> these findBuildID, makeStringError, linkToBuildIdDir functions are not written from the scratch.
> They were moved without modifications from ELF/ELFObjcopy.cpp.
> I would prefer to not change them, since it would be separate refactoring not related to the current one.
>
> Would it be OK, to make those changes as a separate patch?
I see. Sorry, I haven't realized it. Sure, then lets keeps them as is for now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91028/new/
https://reviews.llvm.org/D91028
More information about the llvm-commits
mailing list