[PATCH] D91362: [SelectionDAG] Add llvm.vector.{extract,insert} intrinsics

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm added inline comments.


================
Comment at: llvm/docs/LangRef.rst:15990
+"""""""
+This is an overloaded intrinsic.
+
----------------
Other intrinsics using this phrase also indicate in a following sentence what types are supported, I think we should do that here.


================
Comment at: llvm/docs/LangRef.rst:16000
+
+The '``llvm.vector.insert.*``' intrinsics insert a subvector into another vector
+at a given index. The return type matches the type of the vector we insert into.
----------------
The term "subvector" does not appear to be defined anywhere in the langref that I can see. I wonder if the term could be introduced along with scalable vectors in the "Vector Type" section. Alternatively there may be a way to write this sentence without using the jargon "subvector".

For example: "The 'llvm.vector.insert.*' intrinsics insert a non-scalable vector into a scalable vector at the given index. Conceptually, this can be used to build a scalable vector out of non-scalable vectors.".


================
Comment at: llvm/docs/LangRef.rst:16027
+"""""""
+This is an overloaded intrinsic.
+
----------------
Same comment here for a sentence describing valid types.


================
Comment at: llvm/docs/LangRef.rst:16037
+
+The '``llvm.vector.extract.*``' intrinsics extract a subvector from another
+vector starting from a given index. The return type must be explicitly
----------------
Same comment here for the subvector language.

Suggested language:

"The 'llvm.vector.extract.*' intrinsics extract a non-scalable vector from a scalable vector at the given index. Conceptually, this can be used to decompose a scalable vector into non-scalable parts."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91362/new/

https://reviews.llvm.org/D91362