[PATCH] D91028: [llvm-objcopy][NFC] replace class Buffer/MemBuffer/FileBuffer with streams.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I've skimmed this briefly, and it looks generally okay, but I've got too much else going on to give this a proper review. I'd prefer it if somebody else could take a look.



================
Comment at: llvm/tools/llvm-objcopy/Util.h:9
+
+#ifndef LLVM_TOOLS_OBJCOPY_UTIL_H
+#define LLVM_TOOLS_OBJCOPY_UTIL_H
----------------
Here and below.


================
Comment at: llvm/tools/llvm-objcopy/Util.h:23-26
+  } else if (OutputFileName == "/dev/null") {
+    raw_null_ostream Out;
+    return Write(Out);
+  } else {
----------------
No need for else after return.


================
Comment at: llvm/tools/llvm-objcopy/Util.h:43-44
+  }
+
+  llvm_unreachable("Unknown File kind!");
+}
----------------
You don't need this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91028/new/

https://reviews.llvm.org/D91028