[PATCH] D91414: [RISCV] Use a macro to simplify getTargetNodeName
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 16 01:35:56 PST 2020
frasercrmck added a comment.
In D91414#2393793 <https://reviews.llvm.org/D91414#2393793>, @asb wrote:
> I think moving `NODE_NAME_CASE(foo)` to the left so it's aligned where the `case` statement would be (same as the equivalent in X86ISelLowering and AMDGPUISelLowering) would be slightly better. I wouldn't be opposed to using `// clang-format off` to stop clang-format from reformatting (though it seems more common in LLVM right now to just ignore clang-format's preference).
>
> But basically this looks good to me, and I leave it to your judgement if you want to further mess with the whitespace as suggested above. Thanks Fraser!
Yep okay I'll align the cases left and go with `clang-format off/on` even though it's rarely used in the codebase. That should help to avoid having people use clang-format and wonder what's going on or manually having to undo bits. It's meant to make developers' lives easier, after all :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91414/new/
https://reviews.llvm.org/D91414
More information about the llvm-commits
mailing list