[PATCH] D90848: llvmbuildectomy - part 2

Fri Nov 13 14:24:26 PST 2020

tstellar added a comment.

In D90848#2395095 <https://reviews.llvm.org/D90848#2395095>, @leonardchan wrote:

>> There was an inconsistency in the LLVMBuild.txt for LLVM Frontend: OpenACC wasn't listed but it was part of the CMake infrastructure. A side effect of the llvmbuildectomy has been to remove that inconsistency and register OpenACC as a regular component.
>>
>> Looking at the error log, there is a missing libLLVMFrontendOpenACC.a
>> But I cannot see any reference to FrontendOpenACC in the build log, just as if it wasn't build, which is odd.
>> I failed to reproduce your issue, but does that OpenACC stuff rings any bell? Can you force building that component and see what happens?
>
> Forcing a build of OpenACC then re-running the test fixes my issue. Is there perhaps someway in cmake to indicate that this library should just automatically be built whenever I run `ninja check-llvm`?
>
> My cmake invocation also if it helps is:
>
>   cmake -GNinja       -DCMAKE_BUILD_TYPE=Debug       -DCMAKE_C_COMPILER=/usr/local/google/home/leonardchan/fuchsia/prebuilt/third_party/clang/linux-x64/bin/clang       -DCMAKE_CXX_COMPILER=/usr/local/google/home/leonardchan/fuchsia/prebuilt/third_party/clang/linux-x64/bin/clang++         -DLLVM_ENABLE_LLD=ON       -DCMAKE_EXPORT_COMPILE_COMMANDS=ON       -DLLVM_ENABLE_PROJECTS="clang"   -DLLVM_ENABLE_LIBCXX=On /usr/local/google/home/leonardchan/llvm-monorepo/llvm-project-5/llvm
>
> followed by `LIT_FILTER=booleans.test ninja check-llvm`.

Are there any OpenACC specific tests?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90848/new/

https://reviews.llvm.org/D90848