[PATCH] D90848: llvmbuildectomy - part 2

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 13:53:41 PST 2020


Meinersbur added a subscriber: clementval.
Meinersbur added a comment.

In D90848#2394970 <https://reviews.llvm.org/D90848#2394970>, @serge-sans-paille wrote:

> There was an inconsistency in the LLVMBuild.txt for LLVM Frontend: OpenACC wasn't listed but it was part of the CMake infrastructure. A side effect of the llvmbuildectomy has been to remove that inconsistency and register OpenACC as a regular component.

Such inconsistencies and avoiding those in the future were why I strongly preferred this version over llvmbuildectomy version (D89142 <https://reviews.llvm.org/D89142>). OpenACC was probably just forgotten in D83649 <https://reviews.llvm.org/D83649>. Ping @clementval who authored this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90848/new/

https://reviews.llvm.org/D90848



More information about the llvm-commits mailing list