[PATCH] D91511: [JumpThreading] Call eraseBlock when folding a conditional branch

Sun Nov 15 21:47:54 PST 2020

yrouban added a comment.

In D91511#2396576 <https://reviews.llvm.org/D91511#2396576>, @kazu wrote:

> The problem caused by D91017 <https://reviews.llvm.org/D91017> is due to the jump threading pass not updating edge probabilities (as addressed in this patch).

D91017 <https://reviews.llvm.org/D91017> is NFC, why does it reveal the bug in JumpThreading while it has not been seen without D91017 <https://reviews.llvm.org/D91017>? Can we create a test case, which passes without D91017 <https://reviews.llvm.org/D91017> but fails with it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91511/new/

https://reviews.llvm.org/D91511