[PATCH] D91511: [JumpThreading] Call eraseBlock when folding a conditional branch

Sun Nov 15 20:55:01 PST 2020

yrouban added a comment.

The patch looks good, but I have some concerns.

> //This patch is one of the steps before we can safely re-apply D91017 <https://reviews.llvm.org/D91017>.//

Will there be any other patches? Please add links if any and dependencies to D91017 <https://reviews.llvm.org/D91017>.
Could you please describe the problem that prevents D91017 <https://reviews.llvm.org/D91017>?

================
Comment at: llvm/test/Transforms/JumpThreading/thread-prob-2.ll:13
+  br i1 %cond, label %bb.31, label %bb.12
+; CHECK: eraseBlock bb.cond
+
----------------
Would it be possible to add checks that describe the CFG change like:
 ; CHECK-LABEL: @foo
 ; CHECK: bb.entry:
 ; CHECK-NEXT:   br i1 %cond, label %bb.31, label %bb.12
 ; CHECK-NOT: bb.cond:

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91511/new/

https://reviews.llvm.org/D91511