[PATCH] D89845: Add the ability to extract the unwind rows from DWARF Call Frame Information.

[Greg Clayton via Phabricator via llvm-commits]

clayborg added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:508
+      // location is preceded by a segment selector of the given length
+      auto NewAddress = Inst.getOperandAsUnsigned(CFIP, 0);
+      if (!NewAddress)
----------------
MaskRay wrote:
> This needs to consider the pointer encoding in FDE.
The CFIProgram::parse() already did:
```
    case DW_CFA_set_loc:
      // Operands: Address
      addInstruction(Opcode, Data.getRelocatedAddress(C));
      break;
```
Do we still need to do something here then?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89845/new/

https://reviews.llvm.org/D89845