[PATCH] D91482: [BasicAA] Remove unnecessary known size requirement

[Nikita Popov via Phabricator via llvm-commits]

nikic planned changes to this revision.
nikic added a comment.

While I believe this change is correct, there are some incorrect AA uses that should be addressed first. There's one in MemorySSA wrt phi translation over decreasing cycles (https://reviews.llvm.org/D87778#inline-852179), and another in ParallelDSP (see test failure).

I think we need to clarify the meaning of LocationSize::unknown() in doc comments, and add a variant of it that means "unknown including negative sizes". The standard pattern for alias() queries is to simply pass both sizes as unknown if you want that behavior, but for getModRefInfo this trick doesn't work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91482/new/

https://reviews.llvm.org/D91482