[PATCH] D88382: [VPlan] Turn VPReductionRecipe into a VPValue

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8078
+    Value *NewVecOp = State.get(getVecOp(), Part);
+    if (getCondOp()) {
+      Value *NewCond = State.get(getCondOp(), Part);
----------------
nit: assign in if() and use below?


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8102
     }
-    State.ValueMap.setVectorValue(I, Part, NextInChain);
+    State.ValueMap.setVectorValue(getUnderlyingInstr(), Part, NextInChain);
   }
----------------
The recipes that get converted should also be updated to use `State` directly to map the result VPValue to the generated IR. Could this just be `State.set(this, NextInChain, Part)`?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:937
     O << ", ";
-    CondOp->printAsOperand(O, SlotTracker);
+    getCondOp()->printAsOperand(O, SlotTracker);
   }
----------------
If it's not too much trouble, it would also be good to add a test to `vplan-printing.ll`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88382/new/

https://reviews.llvm.org/D88382