[PATCH] D90565: [VPlan] Make VPInstruction a VPDef

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7811
+          auto *UV = Def->getUnderlyingValue();
+          if (UV->getType()->isVoidTy())
+            continue;
----------------
gilr wrote:
> Is this still possible? Shouldn't e.g. WidenMemoryInstruction, InterleaveGroup, WidenCall recipes hold an empty VPDef for stores / functions returning void?
Good catch, with the VPDef approach, checking for VoidTy is not needed any longer. Removed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90565/new/

https://reviews.llvm.org/D90565