[PATCH] D91461: [build] normalize components dependencies

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 14 20:57:25 PST 2020


Meinersbur added inline comments.


================
Comment at: llvm/lib/FileCheck/CMakeLists.txt:7
 
-target_link_libraries(LLVMFileCheck LLVMSupport)
+  LLVM_COMPONENTS
+  Support
----------------
thopre wrote:
> I don't see any LLVM_COMPONENTS in the source code, and llvm_add_library used indirectly by add_llvm_component_library knows about LINK_COMPONENTS but not LLVM_COMPONENTS. Is my source outdated and this was introduced recently?
I just noticed the inconsistent plural, not the `LLVM_` prefix. Thanks that you noticed.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91461/new/

https://reviews.llvm.org/D91461



More information about the llvm-commits mailing list