[PATCH] D86988: [Inliner] Run always-inliner in inliner-wrapper

Sat Nov 14 17:01:59 PST 2020

mtrofin added a comment.

In D86988#2394700 <https://reviews.llvm.org/D86988#2394700>, @aeubanks wrote:

> In D86988#2351274 <https://reviews.llvm.org/D86988#2351274>, @mtrofin wrote:
>
>> In D86988#2350788 <https://reviews.llvm.org/D86988#2350788>, @aeubanks wrote:
>>
>>> That would be awesome.
>>> One thing is that AlwaysInliner is a required pass (http://llvm.org/docs/WritingAnLLVMNewPMPass.html#required-passes), meaning it'll run even in the case that something like opt-bisect tells it to be skipped. That's because we need to respect alwaysinline semantics. But if we make InlinerPass required, it'll run even when it's not supposed to. If we could make it a separate pass but use the same exact infra but with a different InlineAdvisor(?) that would work for me. So something like factoring out `InlinerPass::run`.
>>
>> Ack - let me get together a patch then next week - just wanted to first see if there's a fundamental pushback. Thanks!
>
> https://reviews.llvm.org/D91446 looks like a bug that would be obsolete with your proposal.

Ugh - got sidetracked, sorry. I'll get back to this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86988/new/

https://reviews.llvm.org/D86988