[PATCH] D91388: [TableGen] Add frontend/backend phase timing capability

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 14 07:29:32 PST 2020


Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/lib/TableGen/Record.cpp:2614
+      stopTimer();
+      BackendTimer = false;
+  }
----------------
thakis wrote:
> ```
> ../../llvm/lib/TableGen/Record.cpp:2613:7: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
>       BackendTimer = false;
>       ^
> ```
> 
> Was the `if (BackendTime)` supposed to have braces?
Absolutely! Thanks for catching this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91388/new/

https://reviews.llvm.org/D91388



More information about the llvm-commits mailing list