[PATCH] D91418: [LLD][ELF] Rename lld elf driver main function

Reshabh Sharma via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 14 04:20:26 PST 2020


rksharma added a comment.

In D91418#2394337 <https://reviews.llvm.org/D91418#2394337>, @MaskRay wrote:

> I am always trapped on this. In gdb both `b main` and `b ::main` set a breakpoint on `lld::elf::LinkerDriver::main`. For consistency, I would suggest `lld::*::LinkerDriver::link` which is used by COFF and wasm ports. However, that has the name collision problems with the free functions `lld::*::link`... (This may be less of a problem because developers don't often set breakpoints on `link`? :) )

I think renaming it to `link` is a very viable thing to do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91418/new/

https://reviews.llvm.org/D91418



More information about the llvm-commits mailing list