[PATCH] D91338: [X86] Zero-extend pointers to i64 for x86_64

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 19:52:27 PST 2020


pengfei added a subscriber: hjl.tools.
pengfei added a comment.

Hi Harald, thanks for thoroughly answering my questions. I still have doubts intention of this patch. Is there any bug related to it?
I had a look at the ABI and found it says "ILP32 binaries ... should conform to small code model or small position independent code model ...". IMHO, the ILP32 mode is designed for performance which always assumes the address bit 63~32 all zero and uses 32 bits register to reduce code size. Although the extension guarantees the correctness, I think it may go against the original intention of the design.
Nevertheless, I'm not expert on ABI, add @hjl.tools for a review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91338/new/

https://reviews.llvm.org/D91338



More information about the llvm-commits mailing list