[PATCH] D91470: Switch libLLVMFrontendOpenACC to be a regular CMake library and not a "component"

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 18:11:50 PST 2020


clementval added a comment.

In D91470#2395409 <https://reviews.llvm.org/D91470#2395409>, @mehdi_amini wrote:

> I think it is very unusual to have a library in LLVM that isn't used in LLVM and so does not come with any testing, so yes it'd be better to do so.
> I'm not actually sure if llvm-config just relies implicitly on this?

Yeah it makes sense to have tests directly in llvm. Sorry for that I blindly followed the OpenMP stuffs and I should have think twice about it.

> I can land this for now, and you can revert this when adding tests?

Sure go ahead if it fixes the current problem. I can revert together with the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91470/new/

https://reviews.llvm.org/D91470



More information about the llvm-commits mailing list