[PATCH] D91470: Switch libLLVMFrontendOpenACC to be a regular CMake library and not a "component"

Fri Nov 13 17:45:19 PST 2020

clementval added a comment.

In D91470#2395395 <https://reviews.llvm.org/D91470#2395395>, @mehdi_amini wrote:

> In D91470#2395391 <https://reviews.llvm.org/D91470#2395391>, @clementval wrote:
>
>> You are right, at the moment it is not connected directly to LLVM itself. It was done like this a little bit blindly follow what was done for for the `libLLVMFrontendOpenMP`.
>
> Is the code in ACC.cpp the kind of thing that could be unit-tested?

Yeah some function could have some unit tests. Would it make sense to send a patch with some tests?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91470/new/

https://reviews.llvm.org/D91470