[PATCH] D91470: Switch libLLVMFrontendOpenACC to be a regular CMake library and not a "component"

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 17:29:25 PST 2020


mehdi_amini created this revision.
mehdi_amini added reviewers: leonardchan, tstellar, clementval.
Herald added subscribers: llvm-commits, hiraditya, mgorny.
Herald added a project: LLVM.
mehdi_amini requested review of this revision.

This library is only used in Flang at the moment and not build and
released with LLVM. Having it as a component is breaking llvm-config:

  $ bin/llvm-config --shared-mode
  llvm-config: error: component libraries and shared library
  
  llvm-config: error: missing: [...]/lib/libLLVMFrontendOpenACC.a


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91470

Files:
  llvm/lib/Frontend/OpenACC/CMakeLists.txt


Index: llvm/lib/Frontend/OpenACC/CMakeLists.txt
===================================================================
--- llvm/lib/Frontend/OpenACC/CMakeLists.txt
+++ llvm/lib/Frontend/OpenACC/CMakeLists.txt
@@ -2,7 +2,7 @@
 tablegen(LLVM ACC.cpp --gen-directive-impl)
 add_public_tablegen_target(acc_cpp)
 
-add_llvm_component_library(LLVMFrontendOpenACC
+add_llvm_library(LLVMFrontendOpenACC
   ACC.cpp # Generated by tablegen above
 
   ADDITIONAL_HEADER_DIRS


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91470.305283.patch
Type: text/x-patch
Size: 461 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201114/9663b98d/attachment.bin>


More information about the llvm-commits mailing list