[PATCH] D89712: [CSSPGO][llvm-profgen] Disassemble text sections

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 17:14:58 PST 2020


wmi added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:232
+
+    uint64_t ImageLoadAddr = PreferredBaseAddress;
+    uint64_t SectionOffset = Section.getAddress() - ImageLoadAddr;
----------------
Can we set PreferredBaseAddress here and don't have to iterate all the sections in setPreferredBaseAddress function?
PreferredBaseAddress = getELFImageLMAForSec(Section);


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89712/new/

https://reviews.llvm.org/D89712



More information about the llvm-commits mailing list