[PATCH] D89707: [CSSPGO][llvm-profgen] Parse mmap events from perf script

[Wei Mi via Phabricator via llvm-commits]

wmi accepted this revision.
wmi added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/tools/llvm-profgen/ErrorHandling.h:9
+
+#ifndef LLVM_TOOLS_LLVM_PROGEN_ERRORHANDLING_H
+#define LLVM_TOOLS_LLVM_PROGEN_ERRORHANDLING_H
----------------
Please fix the clang-tidy warning.


================
Comment at: llvm/tools/llvm-profgen/ErrorHandling.h:22
+LLVM_ATTRIBUTE_NORETURN inline void
+exitWithError(Twine Message, StringRef Whence = StringRef(),
+              StringRef Hint = StringRef()) {
----------------
Like the clang-tidy suggests, better change it to "const Twine&" 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89707/new/

https://reviews.llvm.org/D89707